Fix deserialization with skip#751
Open
PingPongun wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #751 +/- ##
==========================================
+ Coverage 90.83% 90.92% +0.09%
==========================================
Files 13 13
Lines 2040 2314 +274
Branches 370 454 +84
==========================================
+ Hits 1853 2104 +251
- Misses 124 140 +16
- Partials 63 70 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyserdecurrently fails to deserialize when after field withskipattribute there is a non skipped field. (ofc in simple cases, skipped fields could be reordered to be the last ones, but this is not a solution when inheritance is in game, also I've not noticed such limitation ofskipbeing noted anywhere in documentation)This PR adds such case as test scenario ( test failed before fix ) and fixes the problem, by forcing keyword based class initialization (for fields after skipped field)